docker: fix starting containers with a local connection#244290
Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom Jul 19, 2023
Merged
docker: fix starting containers with a local connection#244290SuperSandro2000 merged 1 commit intoNixOS:masterfrom
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
Conversation
Fixes NixOS#244159 Issue is caused by a fix in Go 1.20.6, see upstream issue moby/moby#45935
ofborg
bot
requested review from
amaxine,
mikroskeem,
offlinehacker,
periklis,
tailhook and
vdemeester
ofborg
bot
added
10.rebuild-darwin: 0
amaxine
approved these changes
Jul 19, 2023
Member
Author
|
I'm taking a look but we might need to also patch docker-compose docker/compose#10810 |
Member
Author
|
A new version of docker-compose was already released, see #244013 so no need to patch an upgrade will be enough (for |
amaxine
approved these changes
Jul 19, 2023
Contributor
amaxine
left a comment
amaxine
left a comment
There was a problem hiding this comment.
I'm not sure if 23.05 backports were being taken care of for docker, so that might need doing by hand.
Member
Author
|
23.05 is also at 20.10.23 and from quick glance the automatic backport should work. |
Contributor
|
Successfully created backport PR for |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Fixes #244159
Issue is caused by a fix in Go 1.20.6, see upstream issue moby/moby#45935
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Result of
nixpkgs-review pr 244290run on x86_64-linux 118 packages built: